Re: [spice v2 1/3] server: Fix a pointer to uint64_t cast in spice_replay_next_cmd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> This avoids a compilation error with -Werror on 32 bit systems as the
> pointer size differs from that of an uint64_t.
> 
> Signed-off-by: Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
> ---
>  server/red-replay-qxl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 66acf1e..7a146b6 100644
> --- a/server/red-replay-qxl.c
> +++ b/server/red-replay-qxl.c
> @@ -1156,7 +1156,7 @@ SPICE_GNUC_VISIBLE QXLCommandExt*
> spice_replay_next_cmd(SpiceReplay *replay,
>      case QXL_CMD_UPDATE:
>      case QXL_CMD_SURFACE:
>          info = (QXLReleaseInfo *)cmd->cmd.data;
> -        info->id = (uint64_t)cmd;
> +        info->id = (uint64_t)(uintptr_t)cmd;
>      }
>  
>      replay->counter++;
> --
> 2.6.4
> 

I was suggesting just

  info->id = (uintptr_t)cmd;

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]