> > hey, > > On Fri, Jan 08, 2016 at 11:00:39AM +0000, Frediano Ziglio wrote: > > Changes from v2: > > This patch replace basically patch 3 and 4 of previous version. > > This is more another style change (use a context not related to > > SpiceCoreInterfaceInternal pointer) than a version that wants to > > supercedes the old one. > > Changing context require to store and pass it explicitly so the > > choice between this and the old is quite an opinion. > > I tend to prefer v2. If we want to get an explicit > per-SpiceCoreInterfaceInternal pointer, I'd just append a void *context > pointer to the SpiceCoreInterfaceInternal structure itself rather than > have an additional pointer passed around. > > Christophe > I prefer version 2 too. The change is smaller. Adding a context to SpiceCoreInterfaceInternal is an option but still require to have a separate SpiceCoreInterfaceInternal so I'd prefer the usage of SPICE_CONTAINEROF. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel