Re: [PATCH 1/3] protocol: Add macros to help convert QXLPHYSICAL to/from pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Mon, Dec 28, 2015 at 11:06:37AM +0100, Francois Gouget wrote:
> On 32 bit systems the QXLPHYSICAL integer size deos not match the size
> of a pointer so special care must be taken in the conversions to avoid
> compiler errors with -Werror.

In general (virtualization usecase), you cannot cast between a
QXLPHYSICAL and a pointer, you need to go through some more complicated
conversion. Some care also needs to be taken when using these macros as
QXLPHYSICAL to pointer is going to be truncated on 32-bit.

Since the next patches only change 1 place in the qxl driver, and one
file in spice-server, I would only add these macros to these specific
files, and not add it to spice-protocol.

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]