Re: [common PATCH 1/9 v4] ppc: Always convert surface on BE machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Dec 17, 2015 at 2:32 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> So you were right, when I use this fix with 16bpp on Win7, some areas in
> properties windows are black.
> I also found out, that this patch is not actually needed, because it's the
> other way around.

I thought it was needed in order to byteswap the surfaces?

It byteswaps when saved_want_original == FALSE, and as you pointed out, that happens most of the time.
The one time, that saved_want_original == TRUE is when we blit the transparent surface to 16bpp canvas.
When that happens, we don't want to byteswap, because that for some reason causes artifacts.

Originally I thought, that there are more cases, when saved_want_original == TRUE,
but we still want to byteswap, but as it turns out, that is not the case, and we never want to byteswap,
when saved_want_original == TRUE.

--
Lukas Venhoda
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]