> > On Wed, Dec 16, 2015 at 03:51:11PM +0100, Lukas Venhoda wrote: > > Don't disconnect the display channel, when unsupported compression is > > requested from the client. Not changing the compression is enough. > > > > https://bugs.freedesktop.org/show_bug.cgi?id=92821 > > Acked-by: Victor Toso <victortoso@xxxxxxxxxx> > > Thanks, > > > --- > > Forgot to add bug reference > > Forgot to add break > > > > Changes since v1: > > - Not only for lz4, but now for all unsupported compressions > > --- > > server/dcc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/server/dcc.c b/server/dcc.c > > index b2ee7a6..7c16fc0 100644 > > --- a/server/dcc.c > > +++ b/server/dcc.c > > @@ -1361,11 +1361,11 @@ static int > > dcc_handle_preferred_compression(DisplayChannelClient *dcc, > > case SPICE_IMAGE_COMPRESSION_GLZ: > > case SPICE_IMAGE_COMPRESSION_OFF: > > dcc->image_compression = pc->image_compression; > > - return TRUE; > > + break; > > default: > > spice_warning("preferred-compression: unsupported image > > compression setting"); > > - return FALSE; > > } > > + return TRUE; > > } > > > > int dcc_handle_message(RedChannelClient *rcc, uint32_t size, uint16_t > > type, void *msg) So mainly this function has to return always TRUE (success). Why not ignoring the return value? Or returning void? Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel