Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
Christophe
On Wed, Dec 02, 2015 at 02:14:45PM -0600, Jeremy White wrote:
> We don't need to update the screen when we use a temporary or
> offscreen pixmap.
>
> Signed-off-by: Jeremy White <jwhite@xxxxxxxxxxxxxxx>
> ---
> src/dfps.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/src/dfps.c b/src/dfps.c
> index f113f27..fe0f09e 100644
> --- a/src/dfps.c
> +++ b/src/dfps.c
> @@ -128,6 +128,14 @@ static Bool unaccel (void)
> return FALSE;
> }
>
> +static Bool is_main_pixmap(PixmapPtr pixmap)
> +{
> + ScreenPtr screen = pixmap->drawable.pScreen;
> + if (screen && pixmap == screen->GetScreenPixmap(screen))
> + return TRUE;
> + return FALSE;
> +}
> +
>
> /* Establish a maximum number of disparate regions we'll track before we just
> treat the entire bounding rectangle as having changed.
> @@ -200,7 +208,8 @@ static void dfps_solid (PixmapPtr pixmap, int x_1, int y_1, int x_2, int y_2)
> fbFill(&pixmap->drawable, info->pgc, x_1, y_1, x_2 - x_1, y_2 - y_1);
>
> /* Track the updated region */
> - dfps_update_box(&info->updated_region, x_1, x_2, y_1, y_2);
> + if (is_main_pixmap(pixmap))
> + dfps_update_box(&info->updated_region, x_1, x_2, y_1, y_2);
> return;
> }
>
> @@ -252,7 +261,8 @@ static void dfps_copy (PixmapPtr dest,
> fbCopyArea(&info->copy_src->drawable, &dest->drawable, info->pgc, src_x1, src_y1, width, height, dest_x1, dest_y1);
>
> /* Update the tracking region */
> - dfps_update_box(&info->updated_region, dest_x1, dest_x1 + width, dest_y1, dest_y1 + height);
> + if (is_main_pixmap(dest))
> + dfps_update_box(&info->updated_region, dest_x1, dest_x1 + width, dest_y1, dest_y1 + height);
> }
>
> static void dfps_done_copy (PixmapPtr dest)
> @@ -277,7 +287,8 @@ static Bool dfps_put_image (PixmapPtr dest, int x, int y, int w, int h,
> if (!(info = dfps_get_info (dest)))
> return FALSE;
>
> - dfps_update_box(&info->updated_region, x, x + w, y, y + h);
> + if (is_main_pixmap(dest))
> + dfps_update_box(&info->updated_region, x, x + w, y, y + h);
>
> fbPrepareAccess(dest);
> fbGetPixmapBitsData(dest, dst, dst_stride, dst_bpp);
> @@ -299,7 +310,8 @@ static Bool dfps_prepare_access (PixmapPtr pixmap, RegionPtr region, uxa_access_
> if (!(info = dfps_get_info (pixmap)))
> return FALSE;
>
> - dfps_update_region(&info->updated_region, region);
> + if (is_main_pixmap(pixmap))
> + dfps_update_region(&info->updated_region, region);
> }
> return TRUE;
> }
> --
> 2.1.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel