Re: [PATCH spice 1/9] build-sys: disable static lib by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> From: Marc-André Lureau <mlureau@xxxxxxxxxx>
> 
> It's not used in general, so no need to build it by default.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 907a275..2eb8128 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -43,7 +43,7 @@ if test x"$ac_cv_prog_cc_c99" = xno; then
>  fi
>  AC_PROG_INSTALL
>  AC_CANONICAL_HOST
> -AC_PROG_LIBTOOL
> +LT_INIT([disable-static])
>  AM_PROG_CC_C_O
>  AC_C_BIGENDIAN
>  AC_PATH_PROGS(PYTHON, python2 python)
> --
> 2.5.0

I tested and you can always turned on the compilation adding an
additional option so I agree.

I also checked the SPECs files we provide and we don't pack static
library files.

Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

I won't merge, I'll wait other possible comments.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]