On Wed, Dec 09, 2015 at 04:47:12PM +0100, Javier Celaya wrote: > Hello > > El 15/09/15 a las 17:57, Christophe Fergeau escribió: > >Hey, > > > >On Fri, Jul 31, 2015 at 03:25:32PM +0200, Christophe Fergeau wrote: > >>On Mon, Jul 27, 2015 at 03:06:12PM +0200, Javier Celaya wrote: > >>>spice_marshaller_flush must be called before writing a message to > >>>calculate pointer offsets. > >>Yes, though so far this was not needed as the only ptr marshaller is > >>used for TunnelChannel::service_add message, which spice-gtk does not > >>support. I assume you hit this bug while working on the same code which > >>led to this spice-common/common/marshallers.c fix? > >Any more details as to why this fix is needed? > > > >Christophe > Sorry Christophe, just realized I did not answer your question. We needed > this patch just for a small experiment, and I forgot about it. It is not > critical or anything, but it improves correctness. It may save some valuable > time to anyone implementing a message with pointers and wondering why their > pointers are NULL at destination ;) > -- Thanks, I've pushed it now with an addition to the log message! Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel