On Tue, Dec 08, 2015 at 09:49:27AM -0500, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > Hey, > > > > On Thu, Dec 03, 2015 at 03:35:34PM +0100, Marc-André Lureau wrote: > > > qemu.git uses -Werror by default, and this is problematic as 2.5.0 > > > > QEMU 2.5.0 I guess? The similar versioning between QEMU and libcacard > > can be confused, better to be explicit when you mention "QEMU" > > > > > doesn't use libcacard.h and it breaks some developpers setup. > > > > > > Remove the warning and release 2.5.2. > > > > > > This change can be reverted in a near future (after 2.5.0 release and > > > a qemu patch is merged?) > > > > I guess merging a patch in QEMU to use libcacard.h before the QEMU 2.5.0 > > release is not an option? > > > > ACK. > > it's a tad late, we are a week away from the release. > > Note that it's only to satisfy qemu developpers building from git with the latest libcacard (or those using Werror) Maybe they could apply this patch locally to their libcacard build, or revert to an older libcacard version? No strong feeling, I'm fine with the patch and a 2.5.2 release. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel