Re: [PATCH 15/22] tests: test_display_base: use a faster wakeup time to easily test multiple client blocking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 2, 2015 at 5:19 PM, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:
> From: Alon Levy <alon@xxxxxxxxx>
>
> ---
>  server/tests/test_display_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
> index c2c5705..575c704 100644
> --- a/server/tests/test_display_base.c
> +++ b/server/tests/test_display_base.c
> @@ -864,7 +864,7 @@ Test *test_new(SpiceCoreInterface *core)
>
>      test->core = core;
>      test->server = server;
> -    test->wakeup_ms = 50;
> +    test->wakeup_ms = 1;
>      test->cursor_notify = NOTIFY_CURSOR_BATCH;
>      // some common initialization for all display tests
>      printf("TESTER: listening on port %d (unsecure)\n", port);
> --
> 2.4.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

NAK. There is no clear reason for changing the wakeup time. Better to
leave it out of the tree and add a doc (on spice-space.org) saying
that it my help to easily testing multiple client blocking.
Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]