I have a favor to ask. I found, to my delight, that this patch solves a problem with Xspice. That is, if I turn off dfps mode, I get drawing glitches similar to the 'bad' screen shot attached. (Correct is attached for reference). I'm trying to build an 0.12.6 spice server and I'd like to fix this issue, so I can't use this patch as it is. I spent some time trying to identify what change seems to help, and the attached patch seems to solve the problem. I'm hoping that someone smarter than me can kibitz on this patch, and let me know if they think it's basically 'safe' or not. Cheers, Jeremy On 11/18/2015 08:33 AM, Frediano Ziglio wrote: >> > >> > On Wed, 2015-11-18 at 08:59 -0500, Frediano Ziglio wrote: >>> > > I would ack but I proposed a change and implemented it so I cannot be >>> > > author and acker >>> > > >>> > > Frediano >> > >> > I would ack it too >> > >> > Pavel >> >
Attachment:
bad.png
Description: PNG image
Attachment:
correct.png
Description: PNG image
diff --git a/server/red_worker.c b/server/red_worker.c
index babb597..ea855ce 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -11053,12 +11053,13 @@ void handle_dev_update(void *opaque, void *payload)
QXLRect *qxl_dirty_rects = msg->qxl_dirty_rects;
uint32_t clear_dirty_region = msg->clear_dirty_region;
+ flush_display_commands(worker);
+
VALIDATE_SURFACE_RET(worker, surface_id);
rect = spice_new0(SpiceRect, 1);
surface = &worker->surfaces[surface_id];
red_get_rect_ptr(rect, qxl_area);
- flush_display_commands(worker);
spice_assert(worker->running);
diff --git a/spice-common b/spice-common
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit 449c5da90f6ab65a49139eb6c70be6004eb4ee31
+Subproject commit 449c5da90f6ab65a49139eb6c70be6004eb4ee31-dirty
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel