Re: [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/23/2015 09:39 PM, Jonathon Jongsma wrote:
On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote:
Acked-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>


I take it back.  This should probably be re-merged with the next patch. See
below.



On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote:
From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>

---
  server/red_worker.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index becd42f..efadd91 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -936,7 +936,7 @@ static void image_surface_init(DisplayChannel *display)
      display->image_surfaces.ops = &image_surfaces_ops;
  }

-static void validate_area(DisplayChannel *display, const SpiceRect *area,
uint32_t surface_id)
+static void surface_update_dest(DisplayChannel *display, RedSurface
*surface,
const SpiceRect *area)
  {
      RedSurface *surface;

This introduces a 'surface' argument while retaining the local 'surface'
variable. That doesn't really make sense. Either this commit should only change
the name (and not the parameters) or we should merge it with the next commit.

Furthermore, the function still uses surface_id.


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]