NACK, see my comments on patch 1/3. This should probably be merged with that
patch.
On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
>
> ---
> server/red_worker.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index efadd91..fc30aff 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -936,11 +936,8 @@ static void image_surface_init(DisplayChannel *display)
> display->image_surfaces.ops = &image_surfaces_ops;
> }
>
> -static void surface_update_dest(DisplayChannel *display, RedSurface *surface,
> const SpiceRect *area)
> +static void surface_update_dest(RedSurface *surface, const SpiceRect *area)
> {
> - RedSurface *surface;
> -
> - surface = &display->surfaces[surface_id];
> if (!surface->context.canvas_draws_on_surface) {
> SpiceCanvas *canvas = surface->context.canvas;
> int h;
> @@ -1037,7 +1034,7 @@ void display_channel_draw_till(DisplayChannel *display,
> const SpiceRect *area, i
> drawable_draw(display, now);
> display_channel_drawable_unref(display, now);
> } while (now != surface_last);
> - surface_update_dest(display, surface, area);
> + surface_update_dest(surface, area);
> }
>
> void display_channel_draw(DisplayChannel *display, const SpiceRect *area, int
> surface_id)
> @@ -1074,7 +1071,7 @@ void display_channel_draw(DisplayChannel *display, const
> SpiceRect *area, int su
> region_destroy(&rgn);
>
> if (!last) {
> - surface_update_dest(display, surface, area);
> + surface_update_dest(surface, area);
> return;
> }
>
> @@ -1090,7 +1087,7 @@ void display_channel_draw(DisplayChannel *display, const
> SpiceRect *area, int su
> drawable_draw(display, now);
> display_channel_drawable_unref(display, now);
> } while (now != last);
> - surface_update_dest(display, surface, area);
> + surface_update_dest(surface, area);
> }
>
> static int red_process_cursor(RedWorker *worker, uint32_t max_pipe_size, int
> *ring_is_empty)
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel