On Fri, Nov 20, 2015 at 01:14:20PM -0500, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- > > On Fri, Nov 20, 2015 at 01:01:30PM -0500, Frediano Ziglio wrote: > > > > > > > > On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote: > > > > > Problems: > > > > > - the Spice_style.odt is outdated; > > > > > - spice_assert recall the standard assert but instead it mainly > > > > > call spice_error which like GLib is fatal and should call exit/abort. > > > > > It is not affected by NDEBUG or other definitions. Why using it > > > > > instead > > > > > of spice_error? > > > > > > > > Note that spice-common has verify.h (from gnulib) which can be used for > > > > truly static checks. I did not notice that there is a > > > > spice_static_assert before ;) > > > > > > > > Christophe > > > > > > > > > > I think you are confusing static assertions here with dynamic ones. > > > > verify.h does compile-time assertions, which is what I call 'static > > assertions': > > > > lz_common.h:62:1: erreur: static assertion failed: "verify (1 == 0)" > > verify(1 == 0); > > so does G_STATIC_ASSERT(), I guess we could remove verify.h from source tree today. Yes, that was Frediano's initial point :) Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel