On Mon, Nov 23, 2015 at 10:56 AM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt <pgrunt@xxxxxxxxxx> wrote: >> It was introduced in 49a8d68303f3d8681a9c61d74e0675279649d480 >> but never used. > > This is the kind of function usually added for completeness (?) of the code. > >> >> Signed-off-by: Pavel Grunt <pgrunt@xxxxxxxxxx> >> --- >> server/red_channel.c | 14 -------------- >> server/red_channel.h | 1 - >> 2 files changed, 15 deletions(-) >> >> diff --git a/server/red_channel.c b/server/red_channel.c >> index 7330ae2..1c9cfc6 100644 >> --- a/server/red_channel.c >> +++ b/server/red_channel.c >> @@ -692,20 +692,6 @@ int red_channel_client_test_remote_cap(RedChannelClient *rcc, uint32_t cap) >> cap); >> } >> >> -int red_channel_test_remote_common_cap(RedChannel *channel, uint32_t cap) >> -{ >> - RingItem *link; >> - >> - RING_FOREACH(link, &channel->clients) { >> - RedChannelClient *rcc = SPICE_CONTAINEROF(link, RedChannelClient, channel_link); >> - >> - if (!red_channel_client_test_remote_common_cap(rcc, cap)) { >> - return FALSE; >> - } >> - } >> - return TRUE; >> -} >> - >> int red_channel_test_remote_cap(RedChannel *channel, uint32_t cap) >> { >> RingItem *link; >> diff --git a/server/red_channel.h b/server/red_channel.h >> index 4deecb6..16e9976 100644 >> --- a/server/red_channel.h >> +++ b/server/red_channel.h >> @@ -423,7 +423,6 @@ int red_channel_client_test_remote_common_cap(RedChannelClient *rcc, uint32_t ca >> int red_channel_client_test_remote_cap(RedChannelClient *rcc, uint32_t cap); >> >> /* return true if all the channel clients support the cap */ >> -int red_channel_test_remote_common_cap(RedChannel *channel, uint32_t cap); >> int red_channel_test_remote_cap(RedChannel *channel, uint32_t cap); >> >> /* shutdown is the only safe thing to do out of the client/channel >> -- >> 2.5.0 >> >> _______________________________________________ >> Spice-devel mailing list >> Spice-devel@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/spice-devel > > Acked-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> Sorry for changing my mind, but after reviewing the next patch in the series ... I started thinking that there is no problem in keeping this kind of function. Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel