Re: [PATCH 07/10] worker: fix some fields access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
> 
> ---
>  server/display-channel.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 359b0bf..6184fde 100644
> --- a/server/display-channel.c
> +++ b/server/display-channel.c
> @@ -16,18 +16,18 @@
>  */
>  #include "display-channel.h"
>  
> -void display_channel_compress_stats_reset(DisplayChannel *display_channel)
> +void display_channel_compress_stats_reset(DisplayChannel *display)
>  {
> -    spice_return_if_fail(display_channel);
> +    spice_return_if_fail(display);
>  
>  #ifdef COMPRESS_STAT
> -    stat_reset(&worker->display_channel->quic_stat);
> -    stat_reset(&worker->display_channel->lz_stat);
> -    stat_reset(&worker->display_channel->glz_stat);
> -    stat_reset(&worker->display_channel->jpeg_stat);
> -    stat_reset(&worker->display_channel->zlib_glz_stat);
> -    stat_reset(&worker->display_channel->jpeg_alpha_stat);
> -    stat_reset(&worker->display_channel->lz4_stat);
> +    stat_reset(&display->quic_stat);
> +    stat_reset(&display->lz_stat);
> +    stat_reset(&display->glz_stat);
> +    stat_reset(&display->jpeg_stat);
> +    stat_reset(&display->zlib_glz_stat);
> +    stat_reset(&display->jpeg_alpha_stat);
> +    stat_reset(&display->lz4_stat);
>  #endif
>  }
>  
> --
> 2.4.3

Although this is a good patch I tried to compile actual code with -DCOMPRESS_STAT
and fails in a lot of ways :(

Beside that I would ack this.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]