Re: [PATCH xf86-video-qxl v2] Xspice: handle parameters with value 0, allows --port 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 03, 2015 at 10:39:33AM -0600, Jeremy White wrote:
> As of commit f73ca7e4cc090772652611a4e2b8b95ae64319bc, you can now
> disable the regular port by specifying 0.  This change to the Xspice
> script permits us to take advantage of that change.

Ah thanks for the explanation, makes much more sense now, thanks, ACK.

Christophe

> 
> Signed-off-by: Jeremy White <jwhite@xxxxxxxxxxxxxxx>
> ---
> Since v1: Commit message expanded to explain why this is useful.
> ---
>  scripts/Xspice | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Xspice b/scripts/Xspice
> index 52b1b16..46c5c1e 100755
> --- a/scripts/Xspice
> +++ b/scripts/Xspice
> @@ -256,7 +256,7 @@ var_args = ['port', 'tls_port', 'disable_ticketing',
>      'vdagent_uid', 'vdagent_gid']
>  
>  for arg in var_args:
> -    if getattr(args, arg):
> +    if getattr(args, arg) != None:
>          # The Qxl code doesn't respect booleans, so pass them as 0/1
>          a = getattr(args, arg)
>          if a == True:
> -- 
> 2.1.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]