Re: [PATCH 07/15] worker: misc. set set_client_capabilities_pending in ctor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
>
> Not really necessary, but probably better than FALSE anyway.
> ---
>  server/red_worker.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index fbcab6d..9057cf5 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -10598,6 +10598,7 @@ RedWorker* red_worker_new(QXLInstance *qxl, RedDispatcher *red_dispatcher)
>  #endif
>      red_init_zlib(worker);
>      worker->event_timeout = INF_EVENT_WAIT;
> +    worker->set_client_capabilities_pending = TRUE;
>
>      return worker;
>  }
> --
> 2.4.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Is it used elsewhere than  in guest_set_client_capabilities()?
If not, inside guest_set_client_capabilities() there is nothing
depending on this var, it's set as TRUE when the worker is not running
and set as FALSE in the end of the function ...
Please, let me know if I am missing something here, but for now Nack.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]