On Fri, Oct 23, 2015 at 01:55:22PM +0200, Fabiano Fidêncio wrote: > On Fri, Oct 23, 2015 at 1:54 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > GInetAddress is defined in gio, not glib. Not checking for gio-2.0 in > > SPICE_CHECK_GLIB2 means gio won't be in GLIB2_LIBS, which causes link > > errors when trying to build spice-server. > > --- > > m4/spice-deps.m4 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4 > > index 117d346..59744d2 100644 > > --- a/m4/spice-deps.m4 > > +++ b/m4/spice-deps.m4 > > @@ -142,7 +142,7 @@ AC_DEFUN([SPICE_CHECK_PIXMAN], [ > > # use in the GLIB2_CFLAGS and GLIB2_LIBS variables. > > #------------------ > > AC_DEFUN([SPICE_CHECK_GLIB2], [ > > - PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 2.22) > > + PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 2.22 gio-2.0 >= 2.22) > > ]) > > > > # SPICE_CHECK_PYTHON_MODULES() > > -- > > 2.5.0 > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > ACK considering you have tested it. Yes, I've tested builds with/without it. Linking the spice-server tests fail without this patch. This is pushed now. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel