[PATCH 2/9] server/red_worker: red_draw_qxl_drawable: protect from NULL dereference in case of buggy driver (or recording)

[Frediano Ziglio <fziglio@xxxxxxxxxx>]

From: Alon Levy <alon@xxxxxxxxx>

---
 server/red_worker.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/server/red_worker.c b/server/red_worker.c
index ef529f1..225c272 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -4203,6 +4203,11 @@ static void red_draw_qxl_drawable(RedWorker *worker, Drawable *drawable)
 
     image_cache_aging(&worker->image_cache);
 
+    if (!canvas) {
+        spice_warning("ignoring drawable to destroyed surface %d\n", drawable->surface_id);
+        return;
+    }
+
     region_add(&surface->draw_dirty_region, &drawable->red_drawable->bbox);
 
     switch (drawable->red_drawable->type) {
-- 
2.4.3

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel