Hey, On Tue, Oct 20, 2015 at 03:25:41PM +0200, Francois Gouget wrote: > On Tue, 20 Oct 2015, Victor Toso wrote: > [...] > > Sorry, I wasn't able to fully review it yet. > > I've made a comment which I think you have missed, related the check for > > gst plugins. What do you think about it? > > Sorry. I forgot to reply to it. > I don't think issuing an error makes much sense: > * We don't need these elements to compile spice / spice-gtk. > * They are not even needed to run either spice / spice-gtk since the > builtin MJPEG code is still there and that has no GStreamer > dependency. > * The system spice / spice-gtk is compiled on is not necessarily the > one it will be run on. So a build-time check does not really help. > > I can however add these checks as a warning to inform developers of > potential issues for the most common case. > Yes, I agree that warning is enough. Thanks, Victor Toso _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel