On Fri, Oct 09, 2015 at 07:32:33PM +0300, Michael Tokarev wrote:
> Well, not exactly. Why don't you keep the variables in the final
> SPICE_COMMON_{CFLAGS,LIBS} line my first patch does, instead of
> expanding the values at configure time? This way it will be possible
> to override the components in a common way at make time. I'm referring
> to the first hunk, below:
Right, forgot about this, I don't mind at all either way, for my use
cases it's all the same (but I understand what you want to achieve)
> > +SPICE_COMMON_CFLAGS="$PIXMAN_CFLAGS $SMARTCARD_CFLAGS $CELT051_CFLAGS $GLIB2_CFLAGS $OPUS_CFLAGS $GL_CFLAGS"
> > +SPICE_COMMON_LIBS="$PIXMAN_LIBS $CELT051_LIBS $GLIB2_LIBS $OPUS_LIBS $GL_LIBS"
>
> Why not use
>
> +SPICE_COMMON_CFLAGS='$(PIXMAN_CFLAGS) $(SMARTCARD_CFLAGS) $(CELT051_CFLAGS) $(GLIB2_CFLAGS) $(OPUS_CFLAGS) $(GL_CFLAGS)'
> +SPICE_COMMON_LIBS='$(PIXMAN_LIBS) $(CELT051_LIBS) $(GLIB2_LIBS) $(OPUS_LIBS) $(GL_LIBS)'
>
> ?
>
> SPICE_CHECK_PIXMAN et al will use AC_DEFINE(PIXMAN_{CFLAGS,LIBS}), so these
> will be included in the final Makefile, and these are used in server/
> correctly, server/ allows to override these. But not spice-common.
I'll send a new version with that in.
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel