On Tue, Oct 13, 2015 at 09:21:23AM +0200, Wolfgang Bumiller wrote:
> Hi
>
> > On October 12, 2015 at 6:08 PM Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> > On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> > >
> > > diff --git a/tests/session.c b/tests/session.c
> > > (...)
> >
> > Was this test working fine for you ? most of the tests in tests/ were
> > not building for me, I get runtime warnings when empty port= or
> > tls-port= values are passed, ...
>
> Yeah I get the warnings, and most tests don't build, I used `make session` in
> the tests/ dir:
>
> $ make session && ./session
> CC session.o
> CCLD session
> /session/uri: (/home/wbumiller/External/spice-gtk/tests/./session:30181):
> Spice-Warning **: spice-session.c:522:spice_parse_uri: key 'tls-port' without
> value
> (/home/wbumiller/External/spice-gtk/tests/./session:30181): Spice-Warning **:
> spice-session.c:522:spice_parse_uri: key 'port' without value
> OK
Ah ok, good that we are seeing the same behaviour :) Fwiw, the warnings
are avoided with:
diff --git a/tests/session.c b/tests/session.c
index 0b57e7e..aecc009 100644
--- a/tests/session.c
+++ b/tests/session.c
@@ -16,19 +16,19 @@ static void test_session_uri(void)
} tests[] = {
/* Arguments with empty value */
{ "localhost", "5900", NULL,
- "spice://localhost?port=5900&tls-port=",
+ "spice://localhost?port=5900",
"spice://localhost?port=5900&" },
{ "localhost", "5910", NULL,
- "spice://localhost?tls-port=&port=5910",
+ "spice://localhost?port=5910",
"spice://localhost?port=5910&" },
{ "localhost", NULL, "5920",
- "spice://localhost?tls-port=5920&port=",
+ "spice://localhost?tls-port=5920",
"spice://localhost?tls-port=5920" },
{ "127.0.0.1", NULL, "5930",
- "spice://127.0.0.1?port=&tls-port=5930",
+ "spice://127.0.0.1?tls-port=5930",
"spice://127.0.0.1?tls-port=5930" },
{ "::1", NULL, "5940",
- "spice://[::1]?port=&tls-port=5940",
+ "spice://[::1]?tls-port=5940",
"spice://[::1]?tls-port=5940" },
};
I can send that as a proper git patch on top of your changes if you want, or
feel free to integrate this in your series.
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel