On Thu, Oct 08, 2015 at 04:46:56PM +0300, Yedidyah Bar David wrote: > On Thu, Sep 10, 2015 at 4:20 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > On Thu, Sep 10, 2015 at 03:14:14PM +0300, Yedidyah Bar David wrote: > >> for ovirt use ovirt-guest-tools-setup > >> > > > > This rename can probably be squashed in 1/8 ? > > > > > >> Allow passing a custom DISPLAYED_VERSION and EXE_VERSION > > > > Can you make this a separate commit, > > Done > > > and explain the intent of these 2 > > version numbers? > > One sets the -VERSION part of the installer exe filename, > which we want to be empty in ovirt, and the other sets the > displayed version (in the registry) which we want to be > our version (currently 3.6.0-something). > > Changed the commit message accordingly, please tell me if > you think further clarification is needed. I guess this will be enough, I'll let you know when you send a v2 of the series with these changes. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel