Hi, On Mon, Oct 05, 2015 at 04:06:20PM +0200, Wolfgang Bumiller wrote: > > > > On October 5, 2015 at 2:53 PM Victor Toso <lists@xxxxxxxxxxxxxx> wrote: > > > Could you please also add some tests in tests/session.c ? > > We are lacking tests and this seems a good oportunity ;) > > Sure, apparently spice_uri_create in spice-session.c fails to add brackets when > needed, and I didn't see spice_uri_to_string either at first. Though I'm > wondering if those two sets of URI parsers shouldn't be unified somehow anyway. > Then again I've seen a GUri patch floating around (though I doubt it'll be > adopted very quickly...). Indeed :( The bz if you are interested to follow it is: https://bugzilla.gnome.org/show_bug.cgi?id=746993 > (This one: > http://lists.freedesktop.org/archives/spice-devel/2015-March/019288.html ) > > Going to send v2 in a bit. > thanks, toso _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel