On Mon, 21 Sep 2015, Christophe Fergeau wrote: [...] > > - st->msg_data = in; > > Not very clear in this commit why you needed to stop storing the message > within the display_stream structure, and makes the diff bigger than it > could, I guess I'll find an explanation when looking at the commits > introducing gstreamer ;) This patch introduces a proper API for the video decoder. Part of that is not having the video decoder depend on the internals of the display_stream structure so it is more reusable. Before this patch channel-display-mjpeg.c has no place to store the frame message. Yet, as far as I can see, it cannot pass it to the mjpeg_src_init() callback that needs it. So removing the display_stream.msg_data field cannot come before this patch. And I don't think it's worth introducing a flawed version of the video decoder API just to fix it in the next patch. -- Francois Gouget <fgouget@xxxxxxxxxxxxxxx> _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel