Re: [PATCH] tests: Fix -Werror=format-zero-length build failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> replay.c: In function 'replay_channel_event':
> replay.c:226:16: error: zero-length gnu_printf format string
> [-Werror=format-zero-length]
>      g_printerr("");
> ---
>  server/tests/replay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/tests/replay.c b/server/tests/replay.c
> index efa97e9..c1a53b1 100644
> --- a/server/tests/replay.c
> +++ b/server/tests/replay.c
> @@ -223,7 +223,7 @@ static QXLInterface display_sif = {
>  
>  static void replay_channel_event(int event, SpiceChannelEventInfo *info)
>  {
> -    g_printerr("");
> +    g_printerr("channel event");
>  
>      if (info->type == SPICE_CHANNEL_DISPLAY &&
>          event == SPICE_CHANNEL_EVENT_INITIALIZED) {
> --
> 2.5.0
>

Actually from https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#g-printerr
this was kind of a no-op so perhaps just removing the line is fine.
There is no call to g_set_printerr_handler call in either spice-server or qemu.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]