Re: [linux-vdagent PATCH v1 1/2] Revert "uinput: fix small leak of screen_info"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK series

Christophe

On Tue, Sep 15, 2015 at 10:39:30AM +0200, Victor Toso wrote:
> This reverts commit 4835df0b642dfc963e7cbaabfe93da86482f0b93.
> 
> uinput only holds reference to screen_info and should not free it.
> The leak should be fixed somewhere else.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1262635
> ---
>  src/vdagentd-uinput.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/vdagentd-uinput.c b/src/vdagentd-uinput.c
> index 1ce9918..47e1b45 100644
> --- a/src/vdagentd-uinput.c
> +++ b/src/vdagentd-uinput.c
> @@ -76,10 +76,6 @@ void vdagentd_uinput_destroy(struct vdagentd_uinput **uinputp)
>  
>      if (uinput->fd != -1)
>          close(uinput->fd);
> -
> -    if (uinput->screen_info != NULL)
> -        free(uinput->screen_info);
> -
>      free(uinput);
>      *uinputp = NULL;
>  }
> -- 
> 2.4.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: pgpfZiT6v2MWZ.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]