On Fri, Sep 11, 2015 at 2:46 PM, Sandro Bonazzola <sbonazzo@xxxxxxxxxx> wrote:
>
>
> On Thu, Sep 10, 2015 at 5:05 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx>
> wrote:
>>
>> On Thu, Sep 10, 2015 at 04:32:46PM +0200, Sandro Bonazzola wrote:
>> > On Thu, Sep 10, 2015 at 3:25 PM, Christophe Fergeau
>> > <cfergeau@xxxxxxxxxx>
>> > wrote:
>> >
>> > > On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote:
>> > > > From: Sandro Bonazzola <sbonazzo@xxxxxxxxxx>
>> > > >
>> > > > Allow to generate the tar.gz by just calling
>> > > > "make ovirt-dist"
>> > > >
>> > > > Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22
>> > > > Signed-off-by: Sandro Bonazzola <sbonazzo@xxxxxxxxxx>
>> > > > Signed-off-by: Yedidyah Bar David <didi@xxxxxxxxxx>
>> > > > ---
>> > > > Makefile | 5 +++++
>> > > > 1 file changed, 5 insertions(+)
>> > > > create mode 100644 Makefile
>> > > >
>> > > > diff --git a/Makefile b/Makefile
>> > > > new file mode 100644
>> > > > index 0000000..0a7afda
>> > > > --- /dev/null
>> > > > +++ b/Makefile
>> > > > @@ -0,0 +1,5 @@
>> > > > +OVIRT_WGT_VERSION="3.6.0"
>> > > > +
>> > > > +ovirt-dist:
>> > > > + tar -c --transform 's,^\.,ovirt-wgt,' --exclude=.git
>> > > --exclude=ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz . | \
>> > > > + GZIP=$(GZIP_ENV) gzip -c >
>> > > > ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz
>> > >
>> > > Looks like 'git archive --prefix ovirt-wgt-${OVIRT_WGT_VERSION}
>> > > --format=tar | gzip -c > ovirt-wgt-${OVIRT_WGT_VERSION}.tar.gz
>> > >
>> >
>> > If you tar xz the generated tarball and then try to run again make dist
>> > it
>> > will fail missing the .git directory.
>> > I'd prefer to avoid having a make dist not working on extracted sources.
>>
>> On the other hand, the non-git-archive version will tar mostly
>> everything which is in the working tree (and I tend to accumulate a lot
>> of cruft in there).
>
>
> good point.
>
>>
>>
>> > ovirt-dist is because of the ovirt version involved in tarball name. Not
>> > sure that out of ovirt such version make sense.
>>
>> Actually, this really depends on what you expect to get in the
>> tarball... .nsis script + driver binaries ? Or just the same content as
>> what would be generated by git archive?
>
>
> same content as what would be generated by git archive, just working also
> without the .git.
Not sure it should be part of 'make dist', but I think it will help if we
also have somewhere the git hash inside the tarball/build/iso image/installed
apps. Not sure what's the best place to put this into. To do that we do need
.git .
--
Didi
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel