Re: [PATCH] spice_timer_queue: fix access after free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 03, 2015 at 05:09:31AM -0400, Frediano Ziglio wrote:
> 
> > 
> > Hey,
> > 
> > On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrote:
> > > Do not access to timer after we call the associated function.
> > > Some of these callbacks can free timer making the pointer pointing
> > > to freed data.
> > 
> > Some callbacks are calling
> > spice_timer_remove()/spice_timer_queue_destroy() which then frees
> > the SpiceTimer instance? Or is something more complicated happening?
> > 
> > Christophe
> > 
> 
> Yes, the callback calls spice_timer_remove.

Can you replace "can free timer" with "can call spice_timer_remove" in
the log? ACK with that changed.

Christophe

Attachment: pgpMOXOP0kFF7.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]