On Mon, Aug 24, 2015 at 02:19:23PM +0200, Victor Toso wrote: > Hi, > > On Mon, Aug 24, 2015 at 02:11:47PM +0200, Christophe Fergeau wrote: > > On Fri, Aug 14, 2015 at 06:24:31PM +0200, Victor Toso wrote: > > > - By either using SPICE_ALIGNED_CAST to false positives and > > > SPICE_UNALIGNED_CAST to the cast that could lead to problems; or > > > > Same comment as usual about the SPICE_ALIGNED_CAST() needing > > justification. > > Okay! But you meant in the commit log or a comment in the code every > time does defines are used? In the commit log should be enough. This way the day someone asks themselves "why is this marked as SPICE_ALIGNED_CAST()?", git blame will easily answer that question. Christophe
Attachment:
pgpXfeRfU73US.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel