On Fri, Aug 21, 2015 at 08:28:10AM -0400, Frediano Ziglio wrote: > > > > Update the documentation about the return value, and how to watch for > > connection success. > > > > Releated to: > > https://bugzilla.redhat.com/show_bug.cgi?id=1253848 > > --- > > gtk/spice-session.c | 6 +++++- ^ it is src now since caf28401cac9ece5e314360f8a3a54479df59727 :) > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/gtk/spice-session.c b/gtk/spice-session.c > > index 1a68d7d..234ff54 100644 > > --- a/gtk/spice-session.c > > +++ b/gtk/spice-session.c > > @@ -1489,7 +1489,11 @@ SpiceSession > > *spice_session_new_from_session(SpiceSession *session) > > * Open the session using the #SpiceSession:host and > > * #SpiceSession:port. > > * > > - * Returns: %FALSE if the connection failed. > > + * Returns: %FALSE if the session state is invalid for connection > > + * request. %TRUE if the connection is initiated. To know whether the > > + * connection is established, you must watch for channels creation > > + * (#SpiceSession::channel-new) and the channels state > > + * (#SpiceChannel::channel-event). > > **/ > > gboolean spice_session_connect(SpiceSession *session) > > { > > -- > > 2.4.3 > > > > The patch does not apply upstream. > > Frediano > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel