On Thu, 2015-08-13 at 16:25 +0100, Frediano Ziglio wrote:
> With this series of patches is possible to record what happens to
> spice-server and replay it.
> The main purpose is debugging.
> Note that these patches are quite old and none is mine (I just did
> some minor changes).
> These are part of a long series of patches.
> I left in the former state to start reviewing and commenting.
>
> Personally I would remove the first patch and use another type of
> handler for the extra one. Also changes to server/spice-server.syms
> should be updated.
I don't really have too strong of an opinion, but I also don't see any
reason the two handlers necessarily need to have the same signature.
Also, the name "extra_dispatcher" is rather vague. I'd prefer a nicer
name that gave a bit more indication of what it was for.
>
> Alon Levy (5):
> server/dispatcher: pass message_type to callbacks for consistency
> server/dispatcher: add extra_dispatcher, hack for red_record
> server/red_{record, replay}.[ch]: introduce
> server/red_worker: record to SPICE_WORKER_RECORD_FILENAME
> server/tests/replay: introduce
>
> Marc-André Lureau (2):
> worker: move red_record_event
> worker: move red_record_command
>
> server/Makefile.am | 2 +
> server/dispatcher.c | 12 +-
> server/dispatcher.h | 9 +
> server/main_dispatcher.c | 4 +
> server/make_recorder.sh | 13 +
> server/red_record_qxl.c | 827 ++++++++++++++++++++++++++++++
> server/red_record_qxl.h | 34 ++
> server/red_replay_qxl.c | 1247 ++++++++++++++++++++++++++++++++++++++++++++++
> server/red_replay_qxl.h | 34 ++
> server/red_worker.c | 129 +++--
> server/spice-server.syms | 7 +
> server/tests/Makefile.am | 9 +
> server/tests/replay.c | 346 +++++++++++++
> 13 files changed, 2627 insertions(+), 46 deletions(-)
> create mode 100755 server/make_recorder.sh
> create mode 100644 server/red_record_qxl.c
> create mode 100644 server/red_record_qxl.h
> create mode 100644 server/red_replay_qxl.c
> create mode 100644 server/red_replay_qxl.h
> create mode 100644 server/tests/replay.c
>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel