On 08/05/2015 12:42 PM, Christophe Fergeau wrote:
Hey Uri,
On Mon, Jan 26, 2015 at 12:35:32PM +0200, Uri Lublin wrote:
This patchset touches 3 areas:
Patches 1-4 Xspice script
Add some checks/warnings and run vdagentd with -f command line option
If people prefer I can squash the checks/warning patches
Patches 4-9 fix compiler warnings
Some copromises were made in order to fix those warnings
Patches 10-11 modify README.xspice
Added more example commands I hope would help people
Make xspice+xserver build on a RHEL-6 machine (clone/build more git repos)
If people prefer I can split patch 10 into more patches
Uri Lublin (11):
scripts/Xspice: which: warn if executable is not found
scripts/Xspice: better error messages for missing vdagent binaries
scripts/Xspice: add default spice-vdagent executable names
scripts/Xspice: run vdagentd with -f command line option (fake
uinput)
playback_dir_changed: rename variable "index" to "offset"
vmc_read: rename variable "read" to "nbytes"
configure: include assert.h and values.h (fix compiler warning y1)
README.xspice: clone more repos, add some script lines and more
README.xspice: clone and install xkeyboard-config
Some of these patches were pushed, some were not, any reason for that?
(thinking of at least
uxa: fix compiler warnings (initialize width, height, [xy]Dst_copy)
qxl_ring: replace memcpy with a simple copy_to/from_qxl_ring
)
Hi Christophe,
I did not push what I considered controversial:
7 uxa: fix compiler warnings (initialize width, height, [xy]Dst_copy)
8 configure: include assert.h and values.h (fix compiler warning y1)
9 qxl_ring: replace memcpy with a simple copy_to/from_qxl_ring
8: Marc-Andre commented we should not use AH_TOP. Also he suggested
fixing this in upstream uxa.
7: following comment on 8 -- maybe also need to be fixed in upstream uxa.
For both 7,8 note that upstream uxa (xf86-video-intel) has changed
since the files were copied.
9: Should we copy 1 byte at a time or 8 ? Does it really affect
performance ?
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel