> > On Thu, Jul 23, 2015 at 09:59:37AM -0400, Frediano Ziglio wrote: > > > > > > > > Hey, > > > > > > Not fully sure about adding data to spice.proto which is exclusively > > > used by the dissector, could get a bit confusing. Do you have any idea > > > if these new protocol bits could be used by spice-gtk/spice-server for > > > agent message parsing, or will it always be limited to wireshark use > > > for some reason ? > > > > > > Christophe > > > > > > > Actually only enumeration are generated by all other generators. > > This as functions/code is generated from the protocol statement descending > > to all used types. As these types are used just by dissector (because the > > ws_as attribute is used) they do not generate other code. > > I think some ifdef specification could restrict perhaps the enumerators. > > Actually I added a "WS" prefix to avoid collisions. > > I don't see any point however having some enumerations generated from the > > .proto files and others manually declared in other headers. > > My question was more along the lines of "Do you think > spice-server/spice-gtk could make use of these new spice.proto structs, > or are there some limitations in their code which make these new > spice.proto definitions not adequate for them? > > Christophe > I should have a look at client code. I would ask why this code does not already use similar facilities and instead package network streams manually. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel