Re: [PATCH 05/13] worker: remove useless preload_group_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nitpick. I know that this is Marc-Andre's patch and not yours, but I'd
personally prefer that the commit log was changed to say "unused"
instead of "useless". That's seems much more clear to me.

Jonathon


On Fri, 2015-07-31 at 17:29 +0100, Frediano Ziglio wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
> 
> ---
>  server/red_worker.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index a0adddc..1655bbe 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -982,8 +982,6 @@ typedef struct RedWorker {
>  
>      RedMemSlotInfo mem_slots;
>  
> -    uint32_t preload_group_id;
> -
>      ImageCache image_cache;
>  
>      SpiceImageCompression image_compression;
> @@ -4407,8 +4405,6 @@ static void red_draw_qxl_drawable(RedWorker *worker, Drawable *drawable)
>  
>      image_cache_aging(&worker->image_cache);
>  
> -    worker->preload_group_id = drawable->group_id;
> -
>      region_add(&surface->draw_dirty_region, &drawable->red_drawable->bbox);
>  
>      switch (drawable->red_drawable->type) {


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]