Hi ----- Original Message ----- > Windows guest can have disabled display on the display chanel #0, in > that case it will not be listed in virt-viewer's "View->Displays" menu > > Resolves: > https://bugs.freedesktop.org/show_bug.cgi?id=91489 > --- > I think notify::monitors should stay in create_canvas(), because in that > function the monitor > configuration changes (if the channel does not have > SPICE_DISPLAY_CAP_MONITORS_CONFIG), > so the notify should be emitted. The notify is also emitted when > SPICE_MSG_DISPLAY_MONITORS_CONFIG > is recieved, Windows guests are getting this message only for enabled > displays. > --- > src/channel-display.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/channel-display.c b/src/channel-display.c > index e3f03fc..8837bd0 100644 > --- a/src/channel-display.c > +++ b/src/channel-display.c > @@ -811,8 +811,7 @@ static void spice_display_channel_up(SpiceChannel > *channel) > > /* if we are not using monitors config, notify of existence of > this monitor */ > - if (channel->priv->channel_id != 0) > - g_coroutine_object_notify(G_OBJECT(channel), "monitors"); > + g_coroutine_object_notify(G_OBJECT(channel), "monitors"); > And for guests that do send MonitorConfig messages on channel 0, this is not going to race? _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel