On 07/28/2015 07:16 PM, Frediano Ziglio wrote:
This patch changes the type of 'valid_attributes' and
'attributes_with_arguments'. Both of them are list of strings.
This fixes the build for me on RHEL-6 (python-2.6.6).
Build error is:
File "spice-common/python_modules/ptypes.py", line 67
'end',
^
SyntaxError: invalid syntax
---
python_modules/ptypes.py | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
Weird!
The code is slightly different however. While {'a'} is a set ['a'] is a list. Well.. perhaps could affect performances, a set is sorted/hashed. I tried and a compatible (python 2.6.6, 2.7.8 and 3.4) is set(['a']).
If you agree I can change my patch and put a Signed-off-by.
Yes, one is list and the other is different.
While set is faster than list, with such short lists/sets it's
probably insignificant.
I do not mind having those as sets, with the syntax
set([ attribute names ])
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel