----- Original Message ----- > From: "Jeremy White" <jwhite@xxxxxxxxxxxxxxx> > To: spice-devel@xxxxxxxxxxxxxxxxxxxxx > Sent: Monday, July 27, 2015 10:52:58 PM > Subject: [PATCH] Add libraries such as -lm and -lpthread to the tests build line. > > This prevents a compile error on Debian Jessie, from git, such as this: > /usr/bin/ld: test_playback.o: undefined reference to symbol > 'sin@@GLIBC_2.2.5' > //lib/x86_64-linux-gnu/libm.so.6: error adding symbols: DSO missing from > command line > > This is fairly subtle, and Debian specific. It only happens when you use > autoreconf to generate a new libtool script. Debian patches that script > to require an explicit setting to link with all dependent libraries. > > It should be harmless on other distros, and it does save us Debian guys some > hassle. ACK! I used to have the same problem in another projects as well :-( Not related, but _maybe_ we would need something like this for spice-gtk as well. > > Signed-off-by: Jeremy White <jwhite@xxxxxxxxxxxxxxx> > --- > server/tests/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am > index 3a52d5c..32c97ce 100644 > --- a/server/tests/Makefile.am > +++ b/server/tests/Makefile.am > @@ -20,6 +20,7 @@ LDADD = \ > $(top_builddir)/spice-common/common/libspice-common.la \ > $(top_builddir)/server/libspice-server.la \ > $(GLIB2_LIBS) \ > + $(SPICE_NONPKGCONFIG_LIBS) \ > $(NULL) > > COMMON_BASE = \ > -- > 2.1.4 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel > Best Regards, -- Fabiano Fidêncio _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel