Re: [PATCH spice-server] Use desired image compression for the first image

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-06-26 at 16:31 +0200, Pavel Grunt wrote:
> On Fri, 2015-06-26 at 15:45 +0200, Christophe Fergeau wrote:
> > On Thu, Jun 25, 2015 at 01:28:42PM +0200, Pavel Grunt wrote:
> > > Hi Christophe,
> > > 
> > > On Mon, 2015-06-22 at 14:20 +0200, Christophe Fergeau wrote:
> > > > Hey,
> > > > 
> > > > Seems fine, though it's not clear to me why this would only impact the
> > > > first image? 
> > > It has impact on the first image because other images are compressed by
> > > red_compress_image(). Maybe the mechanism of choosing the compression 
> > > should 
> > > be
> > > the same for both functions (or have just one function for compression ?) 
> > > - 
> > > I
> > > will look into it.
> > 
> > Ah indeed, I was wondering what's up with red_compress_image VS
> > red_marshall_image (_marshall_image seems to be used a bit more than
> > first image, but yeah, seldomly used). Feel free to push this, maybe
> > with a mention of red_compress_image() in the commit log.
> > 
> Thank you Christophe, I am going to send a patch which replaces the "mechanism
> of choosing the compression" by calling red_compress_image() before/instead of 
> pushing this now.

I just pushed this patch.

Pavel

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]