Hey, So Phodav and libgovirt are upstream on jhbuild, I removed this two patches from the series and updated the phodav dependency in the right patch. Pushed! http://cgit.freedesktop.org/spice/spice-jhbuild/log/ Best, On Tue, May 26, 2015 at 04:27:54PM +0200, Victor Toso wrote: > Hi, > > On Tue, May 26, 2015 at 12:09:45PM +0200, Christophe Fergeau wrote: > > ACK series, a few minor comments here and there, but good to push > > whether you decide to address them or not. > > I'll fix the commit logs apply the configure options you > suggested. I don't mind waiting Phodav and libgovirt on upstream > jhbuild. > > Thanks for the review! > - toso > > > > > On Mon, May 25, 2015 at 02:42:46PM +0200, Victor Toso wrote: > > > spice-jhbuild v2 > > > - Addressing Christophe's suggestions: The build is a bit lighter now; > > > spice-gtk and qemu (default modules to build) builds 20 packages > > > instead of ~40 from before; > > > - jhbuild build virt-viewer stil building around ~40 packages as it > > > depends on libvirt-glib; > > > - Specific changes to previous patches below: > > > 13/13: keep modulesets/spice.xml light -- remove gtk/gst builds > > > and other non essential packages. > > > 12/13: Update README > > > 11/13: *removed* - use system xdg images > > > 10/13: Remove module_autogenargs as default but update config options > > > 09/13: libgovirt from gnome instead of github; also created bz for > > > upstream jhbuild: https://bugzilla.gnome.org/show_bug.cgi?id=749688 > > > 08/13: not fixed yet: https://bugzilla.gnome.org/show_bug.cgi?id=745612 > > > 07/13: moved qemu dep changes to last commit `Update dependencies` > > > 06/13: Improved commit log > > > 04/13: *removed* - keep libcacard as it is. > > > 02/13: keep pyparsing tarball (celt051 removed) > > > {01,03,05}/13: Acked > > > > > > spice-jhbuild v1 > > > - So, with the idea of moving the spice moduleset to freedesktop [0] > > > I reworked my changes to better fit upstream. I don't use spice-jhbuild > > > as an extra jhbuild config but as my main one. > > > > > > [0] https://bugs.freedesktop.org/show_bug.cgi?id=89977 > > > > > > With this series of patches in top of Christoph's branch [1] you can > > > jhbuild build gnome-boxes as well as jhbuild build spice-gtk > > > > > > [1] http://cgit.freedesktop.org/~teuf/spice-jhbuild/ > > > > > > Victor Toso (12): > > > moduleset: include gnome-apps-3.18 moduleset > > > moduleset: use celt051 from system packages > > > moduleset: usbredir was moved to spice repository > > > moduleset: virtinst is part of virt-manager > > > moduleset: use libusb from system > > > moduleset: improve qemu configure options > > > moduleset: include Phodav module > > > moduleset: include libgovirt > > > modulesets: update configure options > > > moduleset: update dependencies > > > moduleset: update pyparsing 1.5.5 -> 2.0.3 > > > README: Fix url, include info and more > > > > > > README | 18 ++++++-- > > > modulesets/spice.xml | 128 ++++++++++++++++++++++++++------------------------- > > > 2 files changed, 81 insertions(+), 65 deletions(-) > > > > > > -- > > > 2.4.1 > > > > > > _______________________________________________ > > > Spice-devel mailing list > > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel