Re: [PATCH spice-protocol v2 1/2] Update enums.h for preferred compression message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Mon, Jun 01, 2015 at 04:47:12PM +0200, Javier Celaya wrote:
> ---
>  spice/enums.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/spice/enums.h b/spice/enums.h
> index 18e2f74..6a0ab0b 100644
> --- a/spice/enums.h
> +++ b/spice/enums.h
> @@ -181,6 +181,19 @@ typedef enum SpiceImageType {
>      SPICE_IMAGE_TYPE_ENUM_END
>  } SpiceImageType;
>  
> +typedef enum SpiceImageCompress {
> +    SPICE_IMAGE_COMPRESS_INVALID,
> +    SPICE_IMAGE_COMPRESS_OFF,
> +    SPICE_IMAGE_COMPRESS_AUTO_GLZ,
> +    SPICE_IMAGE_COMPRESS_AUTO_LZ,
> +    SPICE_IMAGE_COMPRESS_QUIC,
> +    SPICE_IMAGE_COMPRESS_GLZ,
> +    SPICE_IMAGE_COMPRESS_LZ,
> +    SPICE_IMAGE_COMPRESS_LZ4,
> +
> +    SPICE_IMAGE_COMPRESS_ENUM_END
> +} SpiceImageCompress;
> +

This turns out to be wrong as someone trying to use an older
spice-server with a newer spice-protocol will get these enum values
twice resulting in build errors :(

Christophe

Attachment: pgpfUsfv19PGp.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]