And please don't cc: Daynix - RedHat <daynix-rh-patches@xxxxxxxxxx> in your series as this is not publicly reachable, and I keep getting bounces. Christophe On Fri, Jul 03, 2015 at 03:18:41PM +0200, Christophe Fergeau wrote: > On Fri, Jul 03, 2015 at 04:05:40PM +0300, Dmitry Fleytman wrote: > > > > > On Jul 3, 2015, at 15:56 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > > > > > On Thu, Jul 02, 2015 at 04:41:32PM +0300, Kirill Moizik wrote: > > >> we need to add redirecting state to singleton since wnd_proc callback should not query usb devices > > >> in the middle of redirecting flow. > > > > > > Why ? > > > > Because in the middle of redirecting flow caller may get inconsistent > > enumeration results (due to device resets performed by UsbDk and > > Windows mechanisms handling those resets), > > UsbDk API intentionally returns error when enumeration is called during start/stop redirection flows. > > All of this should be in the commit log. > > If enumerating returns an error, maybe the wnd_proc callback can just > deal with the error, set a boolean indicating that an enumeration should > be performed when possible, and retry the enumeration as soon as the > 'redirecting' state changes? > > Christophe > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
pgpBf_bjycK5v.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel