[spice-common PATCH 0/7 v2] Fix colors on BE clients, when using image compression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When using image compression on BE client, the color order was wrong.
(BGRA instead of ARGB)

Theese patches try to fix this issue in most of the image compressions.
Only those compressions I could test are changed.

For most of the fixes, new macros for color order were implemented.
Theese macros changed according to the endianness of the machine it runs on.
Original implementation is in QEMU in file qemu-pixman.h

Not all PIXMAN_[a-z] were changed. I don't know what half of them do, nor how to test them.
When I tryed changing them all, it broke my fixes, so I left them as is.
If someone finds a problem with them, I can always patch them later.

---
Changes since v1:
 - Added more image compressions (lz, glz, lz4)
 - Fixed some typos in canvas_util.c
 - Cleaned up pixman-utils.h using the new macros
---

Lukas Venhoda (7):
  pixman_utils: Add macros for color byte ordering
  pixman_utils: Changed color order ifdefs to macros
  ppc; Added supprt for bigendian color byte order
  ppc: Fix colors on ppc when using QUIC
  ppc: Fix colors on ppc when using LZ
  ppc: Fix colors on ppc when using LZ4
  ppc: Fix alpha state checking on BE machines

 common/canvas_base.c  | 20 ++++++++++----------
 common/canvas_utils.c | 16 +++++++++++++++-
 common/pixman_utils.c | 18 +++---------------
 common/pixman_utils.h | 10 ++++++++++
 4 files changed, 38 insertions(+), 26 deletions(-)

--
2.4.3

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]