Yes I changed some long ifdef fields to the new macros, so I will test it and send it in next patch. Will also improve commmit log. Lukas ----- Original Message ----- > From: "Christophe Fergeau" <cfergeau@xxxxxxxxxx> > To: "Lukas Venhoda" <lvenhoda@xxxxxxxxxx> > Cc: spice-devel@xxxxxxxxxxxxxxxxxxxxx > Sent: Thursday, July 2, 2015 1:43:56 PM > Subject: Re: [spice-common PATCH 1/2] ppc: Add macros for color byte ordering > > On Wed, Jul 01, 2015 at 06:20:52PM +0200, Lukas Venhoda wrote: > > When using image compression on PowerPC architecture, colors are in > > wrong order ARGB -> BGRA. > > > > This commit introduces macros, that will change the color order > > according to machine endianness. > > You could mention that this is similar to what qemu is doing. > spice_bitmap_try_as_pixman() could be simplified using these new > constants. > > Christophe > _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel