On Fri, Jun 26, 2015 at 09:52:53AM -0400, Fabiano Fidencio wrote:
>
>
> ----- Original Message -----
> > From: "Christophe Fergeau" <cfergeau@xxxxxxxxxx>
> > To: spice-devel@xxxxxxxxxxxxxxx
> > Sent: Friday, June 26, 2015 3:21:44 PM
> > Subject: Re: [PATCH] build-sys: Fix build with automake < 1.13
> >
> > On Wed, Jun 24, 2015 at 09:57:22AM +0200, Christophe Fergeau wrote:
> > > AC_CONFIG_MACRO_DIRS is not available with older automake versions,
> > > which causes autogen.sh failures on el6. m4_include() can be used
> > > instead.
> > > ---
> > > Not exactly sure this is the right fix, but this works on both el6 and f22
> >
> > Ping?
>
> Yeah, AFAIU AC_CONFIG_MACRO_DIR{,S} was introduced to replace the m4_include(), so it is probably the right fix.
> On the other hand, the 1.13 release (https://lists.gnu.org/archive/html/autotools-announce/2012-12/msg00002.html) says to avoid using this because it will be deprecate soon (and it was in 2012).
>
> So, I would put a big FIXME in that part of the code and we will easily remember of changing it back as soon as it stops working with newer automake versions.
>
> In the end, ACK.
NB: I'll push the exact same patch to spice-gtk as it has the same
issue.
Christophe
Attachment:
pgp8qhGoyXBIr.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel