Re: [spice-protocol PATCH v2] Add monitors_config escape for qxl-win driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 22, 2015 at 07:28:54PM -0400, Sandy Stutsman wrote:
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
> 
> A monitors_config message needs to be sent from the guest to the client
> when monitors are ordered with the "Set Resolution" applet.
> ---
> I think it is best to keep the Windows driver escape structures together in
> the qxl_windows.h file

Why? We have a pre-existing data structure which is not OS-specific, and
the escape handler converts from this QXLEscapeMonitorConfig to QXLHead,
so why not directly pass a QXLHead? An alternative would be to use
VDAgentMonConfig which nearly matches your new struct, but this one
is used for client -> agent communication, I don't know if this could
get confusing or not.

Christophe

Attachment: pgpKEz8x6Kmst.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]