Re: [spice-protocol PATCH] Add monitors_config escape for qxl-win driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 18, 2015 at 07:14:11PM -0400, sstutsma@xxxxxxxxxx wrote:
> From: Sandy Stutsman <sstutsma@xxxxxxxxxx>
> 
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
> 
> A monitors_config message needs to be sent from the guest to the client
> when monitors are ordered with the "Set Resolution" applet.
> ---
>  spice/qxl_windows.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h
> index d1df684..be4f6ec 100644
> --- a/spice/qxl_windows.h
> +++ b/spice/qxl_windows.h
> @@ -7,6 +7,7 @@
>  
>  enum {
>      QXL_ESCAPE_SET_CUSTOM_DISPLAY = 0x10001,
> +    QXL_ESCAPE_MONITOR_CONFIG
>  };
>  
>  typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {
> @@ -15,6 +16,15 @@ typedef struct SPICE_ATTR_PACKED QXLEscapeSetCustomDisplay {
>      uint32_t bpp;
>  } QXLEscapeSetCustomDisplay;
>  
> +typedef struct SPICE_ATTR_PACKED QXLEscapeMonitorConfig {
> +    uint32_t xpos;
> +    uint32_t ypos;
> +    uint32_t xres;
> +    uint32_t yres;

> +    uint32_t bpp;
> +    uint64_t monitors_config;

These last 2 members do not seem to be used in the qxl patch, and only
bpp is filled in the vdagent patch? It seems that QXLHead could be
reused as the arg for QXLEscapeMonitor rather than introducing another
structure?

Christophe

Attachment: pgp8G8CmrgjGr.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]