Connect dialog didn't have a parent window. Changed dialog to a window, because spicy creates no window prior to creating the dialog. No parent can be supplied. Moved the "dialog" code to its own module. --- Changes since v4: - Reworded some shortlogs and commit logs - Squashed "Changed response to gboolean" to "Changed the dialog into a window" - Code cleanup - Removed useless function and variables - Better variable names - Fixed build on gtk2 Changes since v3: - Enabled recent chooser on windows - Changed duplicate blocks of code to for loops - Changed required entries from HOST and PORT to HOST and (PORT or TLS-PORT) Changes since v2: - Split the 3 patches into 5 - Hopefully this new split makes more sense - Changed response from GtkResponseType to gboolean Changes since v1: - Rebased for latest directory structure - Changed response from numbers to GtkResponseType I realize Spicy is just a test tool. I will do this work in remote-viewer as well --- Lukas Venhoda (6): spicy: Move connect dialog to its own file spicy: Changed the dialog into a window spicy: Fixed reselecting in recent chooser spicy: Host and port (or tls) are now required spicy: Replace duplicated code with a for loop spicy: Enable recent chooser on windows po/POTFILES.in | 1 + src/Makefile.am | 2 + src/spicy-connect.c | 254 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/spicy-connect.h | 26 ++++++ src/spicy.c | 135 +--------------------------- 5 files changed, 287 insertions(+), 131 deletions(-) create mode 100644 src/spicy-connect.c create mode 100644 src/spicy-connect.h -- 2.4.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel