Re: [spice-gtk PATCH 1/3] spicy-connect: Connect dialog changed to window

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 08, 2015 at 11:36:36AM +0200, Lukas Venhoda wrote:
> Connect dialog in spicy had no transinient parent.
> It didn't make much sense for it to be a dialog.
> 
> Changed the dialog to window.
> Moved UI definition from code to XML.
> Moved dialog to its own module.
> ---
>  gtk/spicy-connect.c   | 197 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  gtk/spicy-connect.h   |  26 +++++++
>  gtk/spicy-connect.xml | 175 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 398 insertions(+)
>  create mode 100644 gtk/spicy-connect.c
>  create mode 100644 gtk/spicy-connect.h
>  create mode 100644 gtk/spicy-connect.xml

You don't seem to be adding this .xml file to Makefile.am, you need to
make sure it gets installed, and that it's shipped in tarballs. You can
check how virt-viewer deals with it's src/*.xml files.

You probably also need to be more careful to the path to the .xml file
you give to gtk_builder_add_from_file() (side-note, _new_from_file()
would be fine too). Currently, I think it will fail if you try to run
an installed version of spicy, or even if you try to run ./gtk/spicy.

Christophe

Attachment: pgpDd0VZvIkdR.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]